Skip to content

constified str::from_utf8_unchecked_mut #86804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

constified str::from_utf8_unchecked_mut #86804

wants to merge 1 commit into from

Conversation

@fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Jul 2, 2021 •
edited
Loading

This change is small so I think it is fine to just have a fcp for this.

@rust-highfive
Copy link
Contributor

rust-highfive commented Jul 2, 2021

r? @scottmcm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 2, 2021
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Jul 5, 2021

The job x86_64-gnu-llvm-10 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
   Compiling libc v0.2.93
   Compiling std v0.0.0 (/checkout/library/std)
   Compiling compiler_builtins v0.1.46
   Compiling unwind v0.0.0 (/checkout/library/unwind)
error: const-stable function cannot use `#[feature(const_mut_refs)]`
    |
    |
188 | pub const unsafe fn from_utf8_unchecked_mut(v: &mut [u8]) -> &mut str {
    |
    |
help: if it is not part of the public API, make this function unstably const
    |
188 | #[rustc_const_unstable(feature = "...", issue = "...")]
    |
help: otherwise `#[rustc_allow_const_fn_unstable]` can be used to bypass stability checks
    |
188 | #[rustc_allow_const_fn_unstable(const_mut_refs)]


error: const-stable function cannot use `#[feature(const_mut_refs)]`
    |
    |
191 |     unsafe { mem::transmute(v) }
    |
    |
help: if it is not part of the public API, make this function unstably const
    |
188 | #[rustc_const_unstable(feature = "...", issue = "...")]
    |
help: otherwise `#[rustc_allow_const_fn_unstable]` can be used to bypass stability checks
    |
188 | #[rustc_allow_const_fn_unstable(const_mut_refs)]


error: const-stable function cannot use `#[feature(const_mut_refs)]`
    |
    |
191 |     unsafe { mem::transmute(v) }
    |
    |
help: if it is not part of the public API, make this function unstably const
    |
188 | #[rustc_const_unstable(feature = "...", issue = "...")]
    |
help: otherwise `#[rustc_allow_const_fn_unstable]` can be used to bypass stability checks
    |
188 | #[rustc_allow_const_fn_unstable(const_mut_refs)]


error: const-stable function cannot use `#[feature(const_mut_refs)]`
    |
    |
191 |     unsafe { mem::transmute(v) }
    |
    |
help: if it is not part of the public API, make this function unstably const
    |
188 | #[rustc_const_unstable(feature = "...", issue = "...")]
    |
help: otherwise `#[rustc_allow_const_fn_unstable]` can be used to bypass stability checks
    |
188 | #[rustc_allow_const_fn_unstable(const_mut_refs)]


error: const-stable function cannot use `#[feature(const_mut_refs)]`
    |
    |
188 | pub const unsafe fn from_utf8_unchecked_mut(v: &mut [u8]) -> &mut str {
    |
    |
help: if it is not part of the public API, make this function unstably const
    |
188 | #[rustc_const_unstable(feature = "...", issue = "...")]
    |
help: otherwise `#[rustc_allow_const_fn_unstable]` can be used to bypass stability checks
    |
188 | #[rustc_allow_const_fn_unstable(const_mut_refs)]

error: aborting due to 5 previous errors

error: could not compile `core`

@fee1-dead fee1-dead closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@scottmcm scottmcm

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fee1-dead @rust-highfive @rust-log-analyzer @scottmcm